[cxx-interop] Properly import annotations from functions in namespace scope #80986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scope C++ namespaces are imported as Swift enums. This confused the logic that skips importing namespaces for free functions that are imported as member functions via the SWIFT_NAME attribute. rdar://149756644
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
Xazax-hun
changed the title
j-hui
approved these changes
Apr 22, 2025
|
@swift-ci please smoke test Windows |
|
@swift-ci please smoke test Linux |
Xazax-hun
added a commit
that referenced
this pull request
Apr 23, 2025
…space scope Explanation: C++ namespaces imported as Swift enums. This was not accounted for in a condition and that resulted in not importing lifetime annotations for functions that are in namespace scope. This PR fixes that condition. Issue: rdar://149756644 Risk: Low, the fix is very targeted. Testing: Regression test added. Original PR: #80986 Reviewer: @j-hui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ namespaces are imported as Swift enums. This confused the logic that skips importing namespaces for free functions that are imported as member functions via the SWIFT_NAME attribute.
rdar://149756644