[APIGen] Don't record declarations from clang header files #81086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Swift visits an `ExtensionDecl` from an `@objc @implementation` extension, it fetches the implemented Objective-C interface declaration from the header file and adds to the visitor. We don't want these API records from `APIGenRecorder` for Swift API descriptor, because we cannot correctly reason about their API access as they depend on the header group which Swift doesn't know about. Resolves rdar://148943382
cyndyishida
approved these changes
Apr 26, 2025
|
@swift-ci please test |
|
@swift-ci please smoke test macOS |
zixu-w
added a commit
to zixu-w/swift
that referenced
this pull request
Apr 30, 2025
…#81086) When Swift visits an `ExtensionDecl` from an `@objc @implementation` extension, it fetches the implemented Objective-C interface declaration from the header file and adds to the visitor. We don't want these API records from `APIGenRecorder` for Swift API descriptor, because we cannot correctly reason about their API access as they depend on the header group which Swift doesn't know about. Resolves rdar://148943382 <!-- If this pull request is targeting a release branch, please fill out the following form: https://github.com/swiftlang/.github/blob/main/PULL_REQUEST_TEMPLATE/release.md?plain=1 Otherwise, replace this comment with a description of your changes and rationale. Provide links to external references/discussions if appropriate. If this pull request resolves any GitHub issues, link them like so: Resolves <link to issue>, resolves <link to another issue>. For more information about linking a pull request to an issue, see: https://docs.github.com/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> <!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#swift-ci Thank you for your contribution to Swift! --> (cherry picked from commit cd54530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Swift visits an
ExtensionDeclfrom an@objc @implementationextension, it fetches the implemented Objective-C interface declaration from the header file and adds to the visitor.We don't want these API records from
APIGenRecorderfor Swift API descriptor, because we cannot correctly reason about their API access as they depend on the header group which Swift doesn't know about.Resolves rdar://148943382