[embedded] Make the CMake setup for Embedded Concurrency distinguish ARCH and SUBDIR for builds products #81107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
approved these changes
Apr 25, 2025
kubamracek
force-pushed
the
embedded-conc-arch-cmake
branch
from
a102065 to
75ac86a
Compare
|
@swift-ci please smoke test |
kubamracek
force-pushed
the
embedded-conc-arch-cmake
branch
from
75ac86a to
7df157b
Compare
kubamracek
requested review from
justice-adams-apple and
shahmishal
as code owners
|
@swift-ci please test |
…RCH and SUBDIR for builds products
kubamracek
force-pushed
the
embedded-conc-arch-cmake
branch
from
7df157b to
c5aa98a
Compare
|
@swift-ci please test |
ktoso
added a commit
that referenced
this pull request
May 28, 2025
**Description**: This adds "task name" parameter to all task creating functions. This is done in a few ways, e.g. we can backdeploy this to 5.1 in APIs which do not accept the `TaskExecutor` but it they do we provide a version for 6.0+ etc. This was requested in the SE acceptable of this proposal [Acceptance post SE-0469](https://forums.swift.org/t/accepted-with-modifications-se-0469-task-naming/79438). This moves all these declarations to gyb since going through them one by one has become unmaintainable otherwise. **Scope/Impact**: All task creation APIs now gain a new task name parameter. **Risk:** Medium, changes existing APIs rather than adding "even more overloads" though this risk was discussed in the team and accepted. This has a potential to be source breaking it someone used Task.init and friends as function. **Testing**: CI testing, source compatibility suite testing **Reviewed by**: **Original PR:** - #81107 build changes required for this - #80984 **Radar:** --------- Co-authored-by: Kuba Mracek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to unblock #80984. We previously had two conflicting things in the CMake setup: We need to tell add_swift_target_library_single (1) that it's supposed to put the single slice into e.g. a /armv7-apple-none-macho subdirectory, and (2) that the ARCH is e.g. armv7 (so that it can derive the bitwidth for gyb from that). Previously, both the things are communicated via a single "ARCHITECTURE" argument, so let's split that.