[Distributed] thread-safety also for parameter type metadata #81123
+64
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
We had fixed this bug in swiftlang#79381 but missed to realize the same problem existed for parameters as well. This corrects the swift_func_getParameterTypeInfo impl, and also removes the entire "unsafe" method, we no longer use it anywhere. Resolves rdar://146679254
ktoso
force-pushed
the
wip-correct-metadata-handling-distributed
branch
from
e350e74 to
284c060
Compare
ktoso
commented
Apr 26, 2025
| @@ -2907,25 +2907,6 @@ static NodePointer getParameterList(NodePointer funcType) { | |||
| return parameterContainer; | |||
| } | |||
|
|
|||
| static const Metadata *decodeType(TypeDecoder<DecodedMetadataBuilder> &decoder, | |||
There was a problem hiding this comment.
Completely removing this method.
ktoso
commented
Apr 26, 2025
| @@ -3009,8 +2990,21 @@ swift_func_getParameterTypeInfo( | |||
|
|
|||
| SubstGenericParametersFromMetadata substFn(genericEnv, genericArguments); | |||
|
|
|||
| DecodedMetadataBuilder builder( | |||
There was a problem hiding this comment.
no other distributed impl funcs use this, so I'm hoping we're good.
The only other thing swift_func_getParameterCount does not seem like it has any of these problems.
|
@swift-ci please smoke test |
mikeash
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had fixed this bug in #79381 but missed to realize the same problem existed for parameters as well.
This corrects the swift_func_getParameterTypeInfo impl, and also removes the entire "unsafe" method, we no longer use it anywhere.
Resolves rdar://146679254