Skip to content

Add _Builtin_float dependency to Distributed and Synchronization #81141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Apr 28, 2025

This will avoid errors in CI when the latter ones are scheduled before the former.

Addresses rdar://149558141

This will avoid errors in CI when the latter ones are scheduled before
the former.

Addresses rdar://149558141
@edymtt edymtt requested review from ktoso and a team as code owners April 28, 2025 16:58
@edymtt
Copy link
Contributor Author

edymtt commented Apr 28, 2025

@swift-ci please test

@kubamracek
Copy link
Contributor

Nice! 👍

I have definitely hit this rebuild ordering problem in the past and was wondering what's going on :)

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we could even push this lower into the build - it should be implicit for pretty much all targets other than swiftCore.

@edymtt
Copy link
Contributor Author

edymtt commented Apr 29, 2025

That makes sense, although I am a bit wary of touching add_swift_target_library if I can avoid it -- for now I will stick with this solution limited to the libraries I'm sure import _Builtin_float

@edymtt edymtt merged commit ea74546 into swiftlang:main Apr 29, 2025
5 checks passed
@edymtt
Copy link
Contributor Author

edymtt commented Apr 30, 2025

We hit ordering issues with other libraries, so I need to follow Saleem's suggestion -- opened #81211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants