Skip to content

[Concurrency] Bring back ability to get a queue custom executor in executorForEnqueuedJob #81198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stdlib/public/Concurrency/Task.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,11 @@ static SerialExecutorRef executorForEnqueuedJob(Job *job) {
return swift_task_getMainExecutor();
}

if (auto identity = reinterpret_cast<HeapObject *>(jobQueue)) {
return SerialExecutorRef::forOrdinary(
identity, _swift_task_getDispatchQueueSerialExecutorWitnessTable());
}

return SerialExecutorRef::generic();
#endif
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
// RUN: %target-run-simple-swift( -target %target-swift-5.1-abi-triple -parse-as-library -Xfrontend -disable-availability-checking) | %FileCheck %s

// REQUIRES: executable_test
// REQUIRES: concurrency
// REQUIRES: concurrency_runtime
// REQUIRES: concurrency_runtime
// REQUIRES: libdispatch

// REQUIRES: OS=macosx

// Regression test for rdar://150213107

import Darwin
import Dispatch

actor TestActor {
private let queue = DispatchSerialQueue(label: "MYQUEUE")

nonisolated var unownedExecutor: UnownedSerialExecutor {
queue.asUnownedSerialExecutor()
}

init() {
dispatchPrecondition(condition: .notOnQueue(self.queue))

Task.detached {
dispatchPrecondition(condition: .notOnQueue(self.queue))
sleep(1)
await self.start()
}
}

private var startupCompleted: Bool = false
private var startupContinuations: [CheckedContinuation<Void, Never>] = []

func waitForStartup() async {
self.assertIsolated()
guard !startupCompleted else {
print("waitForStartup - completed, bailing")
return
}

print("waitForStartup - adding continuation")
sleep(2)
print("waitForStartup - slept...")

print("waitForStartup - suspend")
await withCheckedContinuation { continuation in
print("waitForStartup - suspend inside")
dispatchPrecondition(condition: .onQueue(self.queue))
startupContinuations.append(continuation)
print("waitForStartup - added")
}
}

private func start() {
dispatchPrecondition(condition: .onQueue(self.queue))
print("start")

startupCompleted = true
for continuation in startupContinuations {
print("start - resuming")
continuation.resume()
}
startupContinuations = []
print("start - FINISHED")
}
}


@main struct Main {
static func main() async {
// CHECK: waitForStartup - adding continuation
// CHECK: waitForStartup - added
// CHECK: start
// CHECK: start - FINISHED
// CHECK: DONE
let test = TestActor()
await test.waitForStartup()
print("DONE")
}
}