Print type inheritances and dictionary types without a space before the colon by default #81204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
force-pushed
the
harlan/col-on-col-off
branch
from
f48dd8d to
e89e2c6
Compare
harlanhaskins
force-pushed
the
harlan/col-on-col-off
branch
from
e89e2c6 to
95e7fcd
Compare
|
Still 262 test failures. Posting now to gather feedback. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the AST printer to respect
PrintOptions::PrintSpaceBeforeInheritancewherever an inheritance clause or dictionary type is printed, and flips the default to false for every client other than SIL.