[6.2] LifetimeDependenceDefUseAddressWalker: avoid infinite recursion. #81247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This utility is used by DependentAddressUseDefWalker which now conservatively follows all possible uses. This could result in the same address being reached multiple times during a def-use walk. Ensure that we don't infinitely recurse. There is no small test case for this, but the fix is trivial and standard practice for such walkers, and this is hit quickly in real usage, so there is no danger of it regressing. Fixes rdar://150403948 ([nonescapable] Infinite recursion compiler crash in lifetime dependence checking) (cherry picked from commit 4512927)
|
@swift-ci test |
DougGregor
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility is used by DependentAddressUseDefWalker which now conservatively
follows all possible uses. This could result in the same address being reached
multiple times during a def-use walk. Ensure that we don't infinitely recurse.
There is no small test case for this, but the fix is trivial and standard
practice for such walkers, and this is hit quickly in real usage, so there is no
danger of it regressing.
Fixes rdar://150403948 ([nonescapable] Infinite recursion compiler crash in
lifetime dependence checking)
(cherry picked from commit 4512927)
main PR: #81246
Risk: Very low. Simply enables an existing recursion check. It can only affect the code path that was already crashing.
Testing: The radar includes a unit test but it isn't appropriate as a lit test.
Reviewed by: @meg-gupta