[6.2][InterfaceGen] Merge exported modules with the same public name in generated interface #81259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a module has the same `public-module-name` as the module being generated and its import is exported, merge it into the same generated interface. Fix various always-imported modules from being printed while here and update all the tests that checked for them. Resolves rdar://137887712. (cherry picked from commit ddddc66)
|
@swift-ci please test |
hborla
approved these changes
May 2, 2025
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module has the same
public-module-nameas the module being generated and its import is exported, merge it into the same generated interface. Use the public module name for any module names being returned from SourceKit requests (eg. in cursor info and documentation). Also fixes various always-imported modules from being printed.(cherry picked from commit ddddc66)
SwiftOnoneSupportremoval). Also added a test case forpublic-module-namespecifically.