[Swiftify] Don't use count from Span inside withUnsafeBufferPointer call #81267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a call like: `ptr.withUnsafeBufferPointer { _ptrPtr in ... }`
`ptr.count` and `_ptrPtr.count` both contain the same value, but when
`ptr` is a `MutableSpan` we get an error when referring to `ptr` inside
a call to `withUnsafeMutableBufferPointer`, so we should use
`_ptrPtr.count` instead.
rdar://150551109
|
@swift-ci please smoke test |
This improves the test coverage, most relevantly for MutableSpan, where some lifetime errors are not emitted unless the function is actually called.
DougGregor
approved these changes
May 3, 2025
std::span imports already have _cxxOverrideLifetime for their return values. __counted_by needs the same, but Cxx may not be available at the macro site, so we introduce _swiftifyOverrideLifetime in SwiftifyImport. rdar://150569220
hnrklssn
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 6, 2025
…all (swiftlang#81267) (cherry picked from commit bd233ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a call like:
ptr.withUnsafeBufferPointer { _ptrPtr in ... }ptr.countand_ptrPtr.countboth contain the same value, but whenptris aMutableSpanwe get an error when referring toptrinside a call towithUnsafeMutableBufferPointer, so we should use_ptrPtr.countinstead.rdar://150551109