[test] Match nocapture to succeed both on main and rebranch
#81375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
rjmccall,
eeckstein,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
ktoso and
adrian-prantl
as code owners
|
@swift-ci please smoke test macOS |
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 8, 2025
… `nocapture` to `captures(none)`" This reverts most test changes in commit f93aba0. These changes will be done a bit differenty on main instead: swiftlang#81375.
AnthonyLatsis
force-pushed
the
nocapture-both-ways
branch
2 times, most recently
from
bf2256e to
833c3dd
Compare
|
@swift-ci please smoke test macOS |
…stream LLVM This attribute was introduced in 7eca38ce76d5d1915f4ab7e665964062c0b37697 (llvm-project). Match it using a wildcard regex, since it is not relevant to these tests. This is intended to reduce future conflicts with rebranch.
…e in upstream LLVM The parameter attribute was introduced in 5ece35df8586d0cb8c104a9f44eaae771de025f5 (llvm-project) and is expected here according to the lowered function body. Match it using a wildcard regex, since it is not relevant to this test. This is intended to reduce future conflicts with rebranch.
AnthonyLatsis
force-pushed
the
nocapture-both-ways
branch
from
833c3dd to
8f14011
Compare
|
@swift-ci please smoke test |
Both the syntax and relative order of the LLVM `nocapture` parameter attribute changed upstream in 29441e4f5fa5f5c7709f7cf180815ba97f611297. To reduce conflicts with rebranch, adjust FileCheck patterns to expect both syntaxes and orders anywhere the presence of the attribute is not critical to the test. These changes are temporary and will be cleaned up once rebranch is merged into main.
AnthonyLatsis
force-pushed
the
nocapture-both-ways
branch
from
8f14011 to
55e5618
Compare
|
@swift-ci please smoke test |
bnbarham
approved these changes
May 8, 2025
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 9, 2025
… `nocapture` to `captures(none)`" This reverts most test changes in commit f93aba0. These changes will be done a bit differenty on main instead: swiftlang#81375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the syntax and relative order of the LLVM
nocaptureparameter attribute changed upstream in llvm/llvm-project#123181. To reduce conflicts with rebranch, adjust FileCheck patterns to expect both syntaxes and orders anywhere the presence of the attribute is not critical to the test. These changes are temporary and will be cleaned up once rebranch is merged into main.