[stdlib] Add 'equal()' function to checking for equal numbers #81586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation 'equal()' can returns all mutually equal values in the input values. Currently, developers can only troubleshoot. ### What's new I add 'equal()' in Algorithm.swift. I add Equal.swift in test. ### Platform Verification Tested on: macOS (arm64) - ✅ Successful build. - ✅ All stdlib tests passed except 3 unrelated known failures: - `abi/macOS/arm64/stdlib-asserts.swift` - `api-digester/stability-stdlib-abi-with-asserts.test` - `benchmark/benchmark-scripts.test-sh` - ✅ New test `SortedByLength.swift` added and passed
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test macOS platform. |
|
👋Hi! First-time contributor here 😄 I noticed that CI hasn’t been triggered on this PR. Just wondering if anything is blocking it or if it needs approval to run. 💻 Looking forward for your reply. Thanks so much! 🙏 |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
lorentey
added
the
swift evolution proposal needed
|
Thanks for taking the effort of putting together a PR! Public API additions like this can only land through the Swift Evolution process. Having an implementation is a good first step; but the addition needs to be pitched and then formally proposed on the forum before we can land it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
'equal()' can returns all mutually equal values in the input values. Currently, developers can only troubleshoot.
What's new
I add 'equal()' in Algorithm.swift.
I add Equal.swift in test.
Platform Verification
Tested on: macOS (arm64)
abi/macOS/arm64/stdlib-asserts.swiftapi-digester/stability-stdlib-abi-with-asserts.testbenchmark/benchmark-scripts.test-shEqual.swiftadded and passed