[region-isolation]fix crash due to missing VectorBaseAddrInst case #81591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
gottesmm
reviewed
May 21, 2025
| @@ -312,6 +312,7 @@ static bool isStaticallyLookThroughInst(SILInstruction *inst) { | |||
| case SILInstructionKind::UncheckedEnumDataInst: | |||
| case SILInstructionKind::StructElementAddrInst: | |||
| case SILInstructionKind::TupleElementAddrInst: | |||
| case SILInstructionKind::VectorBaseAddrInst: | |||
There was a problem hiding this comment.
I think that you need to add a visitor case below.
There was a problem hiding this comment.
I see it was already added below. The best way to make sure this does not happen in the future is for people to add a test in https://github.com/swiftlang/swift/blob/main/test/Concurrency/regionanalysis_trackable_value.sil. Can you add a test case for this there.
gottesmm
approved these changes
May 21, 2025
| @@ -312,6 +312,7 @@ static bool isStaticallyLookThroughInst(SILInstruction *inst) { | |||
| case SILInstructionKind::UncheckedEnumDataInst: | |||
| case SILInstructionKind::StructElementAddrInst: | |||
| case SILInstructionKind::TupleElementAddrInst: | |||
| case SILInstructionKind::VectorBaseAddrInst: | |||
There was a problem hiding this comment.
I see it was already added below. The best way to make sure this does not happen in the future is for people to add a test in https://github.com/swiftlang/swift/blob/main/test/Concurrency/regionanalysis_trackable_value.sil. Can you add a test case for this there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81534
It seems we are missing the case for
VectorBaseAddrInst.VectorBaseAddrInstis statically defined asLookThrough.swift/lib/SILOptimizer/Analysis/RegionAnalysis.cpp
Line 3414 in d985bf6
Regarding tests, similar problems could arise when new
LookThroughinstructions are added in the future. To prevent this, we should consider finding a way to ensure allLookThroughinstructions are properly handled inisStaticallyLookThroughInst. What do you think? Are there any other places that do something similar?