[6.2][Driver][Frontend] -nostdimport and -nostdlibimport should remove the default framework search paths #81621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ian-twilightcoder
commented
May 19, 2025
ian-twilightcoder
commented
- Explanation: This change allows -nostdimport and -nostdlibimport to be useful for embedded development.
- Scope: Only affects clients that are currently using -nostdimport and -nostdlibimport
- Original PRs: [Driver][Frontend] -nostdimport and -nostdlibimport should remove the default framework search paths #81269
- Risk: Risk that some projects were using -nostdimport and -nostdlibimport and expected to still get framework search paths.
- Testing: CI and Apple internal testing
|
Could you elaborate on why is this important on |
nkcsgexi
approved these changes
May 19, 2025
|
Had a discussion with Ian offline and this seems to be necessary for some clients' build. |
…e the default framework search paths -nostdimport and -nostdlibimport only remove the toolchain and usr/lib/swift search paths, and they leave the framework search paths intact. That makes it impossible to get a fully custom SDK environment. Make their behavior match clang's -nostdinc/-nostdlibinc behavior: treat framework and non-framework paths the same. In other words, -nostdinc removes *all* compiler provided search paths, and -nostdlibinc removes *all* SDK search paths. Rename SkipRuntimeLibraryImportPaths to SkipAllImportPaths, and ExcludeSDKPathsFromRuntimeLibraryImportPaths to SkipSDKImportPaths to reflect their updated behavior. Move the DarwinImplicitFrameworkSearchPaths handling from SearchPathOptions to CompilerInvocation, where RuntimeLibraryImportPaths is managed. Rename it to just ImplicitFrameworkSearchPaths, and filter for Darwin when it's set up so that all of the clients don't have to do Darwin filtering themselves later. rdar://150557632
ian-twilightcoder
force-pushed
the
nostdimport-remove-framework-paths
branch
from
e8b2799 to
44b2c08
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.