Platform: Update module maps for the static SDK #81826
Open
+96
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building with the Windows static SDK uncovered issues in the Windows module maps. Some of the headers were missing and others had incorrect layering. This updates the module maps to build with the static Windows SDK.
|
@swift-ci please test Windows platform |
compnerd
reviewed
May 31, 2025
| @@ -175,6 +202,11 @@ module ucrt [system] { | |||
| } | |||
| } | |||
|
|
|||
| module _corecrt_memcpy_s [system] [no_undeclared_includes] { | |||
| @@ -101,6 +123,11 @@ module ucrt [system] { | |||
| export * | |||
| } | |||
|
|
|||
| module stdnoreturn { | |||
| textual header "errno.h" | ||
| } | ||
|
|
||
| module _stdnoreturn [system] [no_undeclared_includes] { |
There was a problem hiding this comment.
Where is this module used? Especially given the ucrt.stdnoreturn module, this seems unused.
| textual header "ctype.h" | ||
| } | ||
|
|
||
| module _errno [system] [no_undeclared_includes] { |
There was a problem hiding this comment.
Given ucrt.errno, is this module used?
| header "stdlib.h" | ||
| export * | ||
| } | ||
|
|
||
| module _ctype [system] [no_undeclared_includes] { |
There was a problem hiding this comment.
Given ucrt.ctype, is this module used?
| @@ -26,31 +26,48 @@ module _complex [system] [no_undeclared_includes] { | |||
| } | |||
|
|
|||
| module _stddef [system] [no_undeclared_includes] { | |||
| header "stddef.h" | |||
| export * | |||
| use corecrt | |||
There was a problem hiding this comment.
Given the removal of the use _stddef is ucrt, is this used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with the Windows static SDK uncovered issues in the Windows module maps. Some of the headers were missing and others had incorrect layering. This updates the module maps to build with the static Windows SDK.