Fix missing Test Result output on Linux when using print
#1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
linux-missing-last-chunk-terminal-output-fix
branch
2 times, most recently
from
791cf9f to
0fce1ee
Compare
plemarquand
force-pushed
the
linux-missing-last-chunk-terminal-output-fix
branch
5 times, most recently
from
78337ff to
7e8505f
Compare
|
I initially tried to work around the issue in node-pty using suggestions in related issues and VS Code itself but because we were using node-pty as a wrapper around a single execution and not as an actual psudoterminal these techniques didn't work. I like the final approach better anyway since wrapping one off executions like this in a pty seems like overkill. |
plemarquand
force-pushed
the
linux-missing-last-chunk-terminal-output-fix
branch
from
7e8505f to
dcafc7e
Compare
node-pty on Linux suffers from a long standing issue where the last chunk of output before a program exits is sometimes dropped, especially if that program produces a lot of output immediately before exiting. See microsoft/node-pty#72 For swift processes that don't require input and may produce a lot of output that could potentially be truncated we can add a new `ReadOnlySwiftProcess` that spawns a child process using node's built in `child_process`. These spawned child processes emit their full output before exiting without the need to resort to flakey workarounds on the node-pty process. When creating new `SwiftExecution`s in future `readOnlyTerminal` should be set to `true` unless the process may require user input. Issue: swiftlang#1393
plemarquand
force-pushed
the
linux-missing-last-chunk-terminal-output-fix
branch
from
dcafc7e to
da26370
Compare
matthewbastien
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-pty on Linux suffers from a long standing issue where the last chunk of output before a program exits is sometimes dropped, especially if that program produces a lot of output immediately before exiting. See microsoft/node-pty#72
For swift processes that don't require input and may produce a lot of output that could potentially be truncated we can add a new
ReadOnlySwiftProcessthat spawns a child process using node's built inchild_process. These spawned child processes emit their full output before exiting without the need to resort to flakey workarounds on the node-pty process.When creating new
SwiftExecutions in futurereadOnlyTerminalshould be set totrueunless the process may require user input.Issue: #1393