-
Notifications
You must be signed in to change notification settings - Fork 76
Support different toolchains per folder #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
plemarquand
merged 10 commits into
swiftlang:main
from
plemarquand:toolchain-per-folder
Apr 29, 2025
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b3e2f53
Support different toolchains per folder
plemarquand 905a6bd
Dont add folder to sourcekit-lsp on startup unless singleServer isn't…
plemarquand b02b77f
Don't tell sourcekit-lsp about .swift-version files
plemarquand 54cee28
Refresh workspace state on folder context creation
plemarquand eb44590
Add swiftly documentation
plemarquand d4804a2
Address some feedback
plemarquand 12381cb
Select folders when ctx.currentFolder is not set
plemarquand 361d5ef
Pick which lsp-server to restart if more than one is available
plemarquand 1e7af5d
Prompt for reload on .swift-version update, add some tests
plemarquand f1e139f
Add restart all LSP server option, give sourcekit-lsp an id with the …
plemarquand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the VS Code Swift open source project | ||
// | ||
// Copyright (c) 2025 the VS Code Swift project authors | ||
// Licensed under Apache License v2.0 | ||
// | ||
// See LICENSE.txt for license information | ||
// See CONTRIBUTORS.txt for the list of VS Code Swift project authors | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import * as vscode from "vscode"; | ||
import { WorkspaceContext } from "../WorkspaceContext"; | ||
import { FolderContext } from "../FolderContext"; | ||
|
||
export default async function restartLSPServer(ctx: WorkspaceContext) { | ||
const toolchainLookup = ctx.folders.reduce( | ||
(acc, folder) => { | ||
acc[folder.swiftVersion.toString()] = acc[folder.swiftVersion.toString()] ?? []; | ||
acc[folder.swiftVersion.toString()].push({ | ||
folder, | ||
fullToolchainName: folder.toolchain.swiftVersionString, | ||
}); | ||
return acc; | ||
}, | ||
{} as Record<string, { folder: FolderContext; fullToolchainName: string }[]> | ||
); | ||
|
||
const toolchains: vscode.QuickPickItem[] = Object.keys(toolchainLookup).map(key => ({ | ||
label: key, | ||
description: toolchainLookup[key][0].fullToolchainName, | ||
detail: toolchainLookup[key].map(({ folder }) => folder.name).join(", "), | ||
})); | ||
|
||
// Skip picking a toolchain if there is only one option to pick | ||
if (toolchains.length === 1) { | ||
return restartLSP(ctx, toolchains[0].label); | ||
} | ||
|
||
const selected = await vscode.window.showQuickPick(toolchains, { | ||
title: "Restart LSP server", | ||
placeHolder: "Select a sourcekit-lsp instance to restart", | ||
canPickMany: false, | ||
}); | ||
|
||
if (!selected) { | ||
return undefined; | ||
} | ||
|
||
return restartLSP(ctx, selected.label); | ||
} | ||
|
||
async function restartLSP(ctx: WorkspaceContext, version: string) { | ||
const languageClientManager = ctx.languageClientManager.getByVersion(version); | ||
await languageClientManager.restart(); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.