LLDB setup backup plan #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general toolchainPath and swiftFolder should be related but on macOS with just a Xcode install swift exe is found in /usr/bin while toolchain is in Xcode package.
Backup is assume relative to the swift binary it is in "../lib" for macOS and Linux and that it is in "../bin" for Windows.
This was
linked to
issues
May 13, 2022
0xTim
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since adding the error message for when lldb setup fails, it has been obvious on a number of platforms it is failing. This PR adds a backup for when the lldb script fails. It makes some assumptions about where the
lldb.dll/so/dylibmight be found. On Linux and Windows this is based on the current structure of the installs. On macOS the backup plan will probably fail, but the script should not fail on macOS so this isn't a huge issue.