Skip to content

Fix runtime files location in package.json #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Sep 26, 2020

Resolves #79.

This requires tagging a new release and republishing on NPM to fully fix the issue.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 26, 2020
@MaxDesiatov MaxDesiatov requested a review from a team September 26, 2020 17:33
@github-actions
Copy link

Time Change: +377ms (2%)

Total Time: 13,356.75ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 186.25ms +5.5ms (2%)
Serialization/Write JavaScript string directly 181ms -1.75ms (0%)
Serialization/Swift Int to JavaScript 4,843.25ms +110ms (2%)
Serialization/Swift String to JavaScript 4,960ms +118.25ms (2%)
Object heap/Increment and decrement RC 3,186.25ms +145ms (4%)

performance-action

Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for fixing this!

@MaxDesiatov MaxDesiatov merged commit 317bab3 into main Sep 26, 2020
@MaxDesiatov MaxDesiatov deleted the runtime-files-fix branch September 26, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.7.0 unavailable on NPM
2 participants