Fix populating default port and headers in HttpFoundationFactory #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. Can you please squash your commits and fix CI reports? |
| @@ -70,7 +74,6 @@ public function createRequest(ServerRequestInterface $psrRequest, bool $streamed | |||
| $server, | |||
| $streamed ? $psrRequest->getBody()->detach() : $psrRequest->getBody()->__toString() | |||
| ); | |||
| $request->headers->replace($psrRequest->getHeaders()); | |||
There was a problem hiding this comment.
How can the created request know about the headers of the psr one if we remove this line?
There was a problem hiding this comment.
They are already parsed few lines above. Without this line removed there is no way to use basic auth with Symfony - header is parsed during request object creation few lines above and then parsed user/password values are being overriden here.
There was a problem hiding this comment.
I kept the line and replaced "replace()" by "add()". This should provide better compat.
nicolas-grekas
changed the title
nicolas-grekas
changed the title
|
Thank you @mleczakm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are few dirty hacks which are required to get symfony up and running as Roadrunner psr7 worker:
$_SERVER['https']to true is required for properly handling non-proxied requests, handled with encryption directly from Roadrunner - same as fix conversion for https requests #770