Store voters in Security #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuilhemN Can you do another PR to add the comments you added in Symfony SE? I think they are quite useful. |
|
Thank you @GuilhemN. |
fabpot
added a commit
that referenced
this pull request
May 1, 2017
This PR was merged into the master branch. Discussion ---------- Store voters in Security [As caught by @xabbuh](symfony/symfony-standard#1064 (comment)), in the docs, voters are stored in `Security`, not in `Voter`. Commits ------- 6185425 Store voters in Security
Merged
|
sure, see #43 |
fabpot
added a commit
that referenced
this pull request
May 1, 2017
This PR was merged into the master branch. Discussion ---------- Add comments Related to #42 and symfony/symfony-standard#1064 Commits ------- 52c22bd Add comments
VolCh
pushed a commit
to VolCh/recipes
that referenced
this pull request
Nov 30, 2017
markovlatkovic
pushed a commit
to markovlatkovic/recipes
that referenced
this pull request
May 24, 2024
This PR was merged into the master branch. Discussion ---------- Add comments Related to symfony/recipes#42 and symfony/symfony-standard#1064 Commits ------- 52c22bd Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As caught by @xabbuh, in the docs, voters are stored in
Security, not inVoter.