Skip to content

Error Overriding the request #8768

Closed
Closed
@Sydney-o9

Description

@Sydney-o9

In Overriding the request, we seem to confuse create with __construct from the Request.

They are not the same.

The following is not correct:

use Symfony\Component\HttpFoundation\Request;
use AppBundle\Http\SpecialRequest;

Request::setFactory(function (
    array $query = array(),
    array $request = array(),
    array $attributes = array(),
    array $cookies = array(),
    array $files = array(),
    array $server = array(),
    $content = null
) {
    return SpecialRequest::create(
        $query,
        $request,
        $attributes,
        $cookies,
        $files,
        $server,
        $content
    );
});

$request = Request::createFromGlobals();

The following is correct:

use Symfony\Component\HttpFoundation\Request;
use AppBundle\Http\SpecialRequest;

Request::setFactory(function (
    array $query = array(),
    array $request = array(),
    array $attributes = array(),
    array $cookies = array(),
    array $files = array(),
    array $server = array(),
    $content = null
) {
    return new SpecialRequest(
        $query,
        $request,
        $attributes,
        $cookies,
        $files,
        $server,
        $content
    );
});

$request = Request::createFromGlobals();

I have sent a PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    HttpFoundationhasPRA Pull Request has already been submitted for this issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions