Removed deprecated contents #11621
Closed
Removed deprecated contents #11621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
May 30, 2019
| @@ -53,17 +53,6 @@ In addition, some components and official bundles provide other value resolvers: | |||
| the controller can be accessed by anonymous users. It requires installing | |||
| the :doc:`Security component </components/security>`. | |||
|
|
|||
| :class:`Symfony\\Bundle\\SecurityBundle\\SecurityUserValueResolver` | |||
There was a problem hiding this comment.
Wow (unrelated to this PR), this is such an implementation detail that I would even vote to completely remove it from 4.2 docs (and just replace the class name and act like nothing changed, it doesn't matter for a framework user)
javiereguiluz
added a commit
that referenced
this pull request
May 31, 2019
…aviereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #11623). Discussion ---------- Deprecate the templating.* options of FrameworkBundle We're correctly removing them in 5.0 (#11621) but we forgot to add the deprecation notice in 4.3. Commits ------- 29b46ec Deprecate the templating.* options of FrameworkBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #11620 and removes deprecated things.
The only remaining deprecation is the
transChoice()method. I'm leaving that for future PRs because @wouterj created a big PR pending to be merged related to that.