#11627 Minor/Patch version fix

[JoppeDC]

According to the docs the composer.json file is setup for automatic minor version upgrades. This is not the case, its setup for patch version upgrades.

[greg0ire]

Indeed:

composer create-project symfony/skeleton my_project && grep symfony my_project/composer.json
        "symfony/console": "4.3.*",
        "symfony/dotenv": "4.3.*",
        "symfony/flex": "^1.1",
        "symfony/framework-bundle": "4.3.*",
        "symfony/yaml": "4.3.*"
        "symfony/polyfill-ctype": "*",
        "symfony/polyfill-iconv": "*",
        "symfony/polyfill-php71": "*",
        "symfony/polyfill-php70": "*",
        "symfony/polyfill-php56": "*"
            "cache:clear": "symfony-cmd",
            "assets:install %PUBLIC_DIR%": "symfony-cmd"
        "symfony/symfony": "*"
        "symfony": {

[greg0ire]

Please squash your commits together.

[ghost]

Looks good to me now. Thank you.

[weaverryan]

Very good catch! I think there's one more thing that most users will need to update:

https://github.com/symfony/skeleton/blob/010e5495eb28fa2a5240ef4d75df61c516e36fb3/composer.json#L56

Please test that first - but I'm pretty sure that this is also something that will lock your Symfony deps to, in this example, 4.3

[JoppeDC]

Very good catch! I think there's one more thing that most users will need to update:

symfony/skeleton:composer.json@010e549#L56

Please test that first - but I'm pretty sure that this is also something that will lock your Symfony deps to, in this example, 4.3

Thanks Ryan. I'll check this tomorrow 😉

[JoppeDC]

@weaverryan After doing some testing, it appears that you indeed need to set the data setting to the correct version.

[wouterj]

Thank you @JoppeDC and congratz with your first contribution!

I've merged this into 4.2, instead of master, as that's the oldest still maintained branch that this fix should apply (3.4 isn't using Symfony Flex/the skeleton yet). In 2119d98, I've fixed 2 minor syntax errors.

Looking forward to see more contributions!