Skip to content

Add documentation for the split env var processor #11674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add documentation for the split env var processor #11674

wants to merge 2 commits into from

Conversation

Orkin
Copy link

@Orkin Orkin commented Jun 5, 2019 •
edited
Loading

Documentation for symfony/symfony#31867

@Orkin Orkin mentioned this pull request Jun 5, 2019
Closed
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Jun 6, 2019
@OskarStark OskarStark changed the title Add documentation for the env processor Add documentation for the explode env var processor Jun 6, 2019
@OskarStark OskarStark added this to the 4.4 milestone Jun 6, 2019
@Orkin Orkin changed the base branch from master to 4.4 June 7, 2019 13:33
@ro0NL
Copy link
Contributor

ro0NL commented Jun 14, 2019

If this feature is accepted, we should try to clarfiy the diff between csv and split.

Perhaps advise to use split by default, and only csv if one needs escaping possibilities.

ro0NL
ro0NL reviewed Jun 14, 2019
View reviewed changes
configuration/env_var_processors.rst Outdated
@@ -380,6 +380,9 @@ Symfony provides the following env var processors:

The ``trim`` processor was introduced in Symfony 4.3.

``env(split:FOO,BAR)``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FOO

ro0NL
ro0NL reviewed Jun 14, 2019
View reviewed changes
@Orkin Orkin changed the title Add documentation for the explode env var processor Add documentation for the split env var processor Jun 15, 2019
@nicolas-grekas
Copy link
Member

Upstream PR has been rejected. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

Assignees
No one assigned
Labels
Status: Needs Review Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Orkin @ro0NL @nicolas-grekas @javiereguiluz @OskarStark @carsonbot