Skip to content

Removed old deprecated directives. #11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

Removed old deprecated directives. #11775

merged 1 commit into from
Jun 20, 2019

Conversation

OskarStark
Copy link
Contributor

@wouterj please check the translation parts of this PR, thank you!

@OskarStark OskarStark added this to the 5.0 milestone Jun 18, 2019
@javiereguiluz javiereguiluz mentioned this pull request Jun 19, 2019
Closed
wouterj
wouterj approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation looks fine!

That whole article should be revamped, but I'll do that in another PR (it's now showing Translation as some sort of message formatter instead of a proper translator, which is a bit weird)

@javiereguiluz
Copy link
Member

Thank you.

@javiereguiluz javiereguiluz merged commit 25b70a3 into symfony:master Jun 20, 2019
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jun 20, 2019
@javiereguiluz
minor symfony#11775 Removed old deprecated directives. (OskarStark)
68dcc69 
This PR was merged into the master branch.

Discussion
----------

Removed old deprecated directives.

@wouterj please check the translation parts of this PR, thank you!

Commits
-------

25b70a3 Removed old deprecated directives.
@OskarStark OskarStark deleted the remove-old-deporecated-directives branch June 20, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @javiereguiluz @wouterj @xabbuh @carsonbot