Skip to content

update used PHPUnit versions #11780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

update used PHPUnit versions #11780

merged 1 commit into from
Jul 5, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 18, 2019 •
edited
Loading

fixes #11759

@xabbuh xabbuh added this to the 4.4 milestone Jun 18, 2019
@xabbuh xabbuh mentioned this pull request Jun 18, 2019
Closed
ro0NL
ro0NL reviewed Jun 18, 2019
View reviewed changes
components/phpunit_bridge.rst
@@ -624,8 +624,9 @@ its ``bin/simple-phpunit`` command. It has the following features:

* Does not embed ``symfony/yaml`` nor ``prophecy`` to prevent any conflicts with
these dependencies;
* Uses PHPUnit 4.8 when run with PHP <=5.5, PHPUnit 5.7 when run with PHP >=5.6
and PHPUnit 6.5 when run with PHP >=7.2;
* Uses PHPUnit 4.8 when run with PHP <=5.5, PHPUnit 5.7 when run with PHP 5.6,
Copy link
Contributor

@ro0NL ro0NL Jun 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure this is a feature really :) i'd prefer a "compatible version" table and keep it straightforward (as this is quite a sentence)

@javiereguiluz javiereguiluz merged commit d05ecdb into symfony:4.4 Jul 5, 2019
javiereguiluz added a commit that referenced this pull request Jul 5, 2019
@javiereguiluz
minor #11780 update used PHPUnit versions (xabbuh)
2d5b8c6 
This PR was merged into the 4.4 branch.

Discussion
----------

update used PHPUnit versions

fixes #11759

Commits
-------

d05ecdb update used PHPUnit versions
@javiereguiluz
Copy link
Member

Thanks Christian for adding this info! While merging I did a reword (8f75f04) to turn the phrase into a table as suggested by Roland.

@xabbuh xabbuh deleted the issue-11759 branch July 5, 2019 08:19
@xabbuh
Copy link
Member Author

xabbuh commented Jul 5, 2019

Thank you Javier! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

Assignees
No one assigned
Labels
PHPUnitBridge Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @javiereguiluz @ro0NL @carsonbot