Set PHP Version requirement to 7.2.5 #12693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
Status: Reviewed
Waiting Code Merge
javiereguiluz
added
On hold
and removed
Waiting Code Merge
|
@HLeithner you are right! However, the new patch versions of contracts haven't been released yet, so 7.2.9 is still the required version. I've put this "On Hold" until they are released, which hopefully will be very soon. Thanks and congrats on your first Symfony Docs contribution! |
xabbuh
approved these changes
Nov 26, 2019
derrabus
approved these changes
Nov 26, 2019
|
Translation contracts 2.0.1 has just been released (https://github.com/symfony/translation-contracts/releases) so this can be merged because PHP 7.2.5 is again the minimum required version of Symfony. |
OskarStark
approved these changes
Nov 30, 2019
|
Thanks Harald. |
javiereguiluz
added a commit
that referenced
this pull request
Nov 30, 2019
This PR was merged into the 5.0 branch. Discussion ---------- Set PHP Version requirement to 7.2.5 Based on the last pull request for 5.0 the minimum PHP Version is 7.2.5 symfony/symfony#34443 That's also the required version in composer.json https://github.com/symfony/symfony/blob/5.0/composer.json#L19 Commits ------- 3d50d78 Set PHP Version requirement to 7.2.5
|
Thanks for merging. Finally we at Joomla set our minimum php version joomla 4 to version 7.2.5 too. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the last pull request for 5.0 the minimum PHP Version is 7.2.5
symfony/symfony#34443
That's also the required version in composer.json
https://github.com/symfony/symfony/blob/5.0/composer.json#L19