[Form] Added article for custom choice fields #13490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 4, 2020
HeahDude
force-pushed
the
feature/form-choice_loader
branch
4 times, most recently
from
a9dccbf to
6b7e871
Compare
HeahDude
requested review from
javiereguiluz,
wouterj,
weaverryan and
OskarStark
weaverryan
reviewed
Apr 4, 2020
HeahDude
force-pushed
the
feature/form-choice_loader
branch
10 times, most recently
from
b525b7a to
e9ecb25
Compare
wouterj
approved these changes
Apr 4, 2020
HeahDude
force-pushed
the
feature/form-choice_loader
branch
from
e9ecb25 to
65a905b
Compare
HeahDude
force-pushed
the
feature/form-choice_loader
branch
4 times, most recently
from
f881ff0 to
e0771a6
Compare
javiereguiluz
approved these changes
Apr 6, 2020
| @@ -131,6 +65,14 @@ implement the ``getParent()`` method (Symfony will make the type extend from the | |||
| generic :class:`Symfony\\Component\\Form\\Extension\\Core\\Type\\FormType`, | |||
| which is the parent of all the other types). | |||
|
|
|||
| .. note:: | |||
|
|
|||
| The PHP class extension mechanism and the Symfony form field extension | |||
There was a problem hiding this comment.
The PHP class extension mechanism
I don't know what this is. Do you mean inheritance?
There was a problem hiding this comment.
I agree we should change that, but I propose to do it in #13488 which targets 3.4 instead. You're review is welcome there too :)
HeahDude
force-pushed
the
feature/form-choice_loader
branch
from
e0771a6 to
50c6867
Compare
|
This PR has been closed because the master has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to add a new page in the form section in master to fix both #6446 and #13120.