Skip to content

[Console] Update lockable_trait.rst #14648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

[Console] Update lockable_trait.rst #14648

merged 1 commit into from
Dec 7, 2020

Conversation

noniagriconomie
Copy link
Contributor

While attending to the SymfonyWorld Online 2020 - Lock & Semaphore: The gatekeepers of your resources
I remembered this feature and found this missed part
For upper branches v5.1+, the Command::SUCCESS is to be used

@carsonbot carsonbot added this to the 4.4 milestone Dec 3, 2020
@OskarStark
Copy link
Contributor

So we should merge this only in 4.4 and keep Command::SUCCESS in the upper branches, right?

@OskarStark OskarStark self-assigned this Dec 4, 2020
@carsonbot carsonbot changed the title Update lockable_trait.rst [Console] Update lockable_trait.rst Dec 4, 2020
@noniagriconomie
Copy link
Contributor Author

@OskarStark

So we should merge this only in 4.4 and keep Command::SUCCESS in the upper branches, right?

Sorry if my desc was not clear :s
Here is the diff accordingly for branches

-return 0;                                            // v4.4
+return Command::SUCCESS;         // v5.1+, as the doc was updated to use the const instead of integer

@OskarStark
Copy link
Contributor

Thank you Antoine.

@OskarStark OskarStark merged commit a1a60fd into symfony:4.4 Dec 7, 2020
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Dec 7, 2020
@OskarStark
Use constant over int. refs symfony#14648
25c6519
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Dec 7, 2020
@OskarStark
Merge branch '5.1' into 5.2
7a0d1c7 
* 5.1:
  remove whitespaces
  Use constant over int. refs symfony#14648
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Dec 7, 2020
@OskarStark
Merge branch '5.2' into 5.x
c7c7bd5 
* 5.2:
  remove whitespaces
  Use constant over int. refs symfony#14648
@noniagriconomie noniagriconomie deleted the patch-16 branch December 24, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees

@OskarStark OskarStark

Labels
Console Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@noniagriconomie @OskarStark @carsonbot