[DependencyInjection] Negated (not:) env var processor #14976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 14, 2021
… (bpolaszek) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [DependencyInjection] Negated (not:) env var processor | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? |no | New feature? | yes | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#14976 This little PR suggests a `not:` env var processor (in a perfect world, I would name it `!:` but only words are accepted as prefixes 🙃) Goal is to _negate_ a boolean env variable. Example usage: ```bash FOO=yes BAR=off ``` ```yaml # config/services.yaml parameters: not_foo: '%env(not:FOO)%' # false not_bar: '%env(not:BAR)%' # true ``` I'm thinking of this for this kind of usages: - `some_prod_related_stuff: '%env(not:APP_DEBUG)%'` - `enabled: '%env(not:bool:key:disabled:query_string:SOME_DSN)%'` ~~Processor raises an exception when preceding resolved value is not a boolean.~~ This processor allows any truthy/falsy values, like `bool:`. Thank you, Ben Commits ------- 56545fd [DependencyInjection] Negated (not:) env var processor
OskarStark
requested changes
Feb 14, 2021
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
Sure, here it is. |
OskarStark
approved these changes
Feb 15, 2021
OskarStark
force-pushed
the
feat/negated-env-var-processor
branch
from
486d495 to
3ff812d
Compare
|
Thanks @bpolaszek for working on this feature, this is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for symfony/symfony#40169: negated env var processor:
Casts to a bool (just as
env(bool:...)does) except it returns the inverted value(falsy values are returned astrue, truthy values are returned asfalse):