Skip to content

[FrameworkBundle] Replace render() with new renderForm() in form documentation #15105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Replace render() with new renderForm() in form documentation #15105

wants to merge 1 commit into from

Conversation

MrYamous
Copy link
Contributor

This is the documentation for #14844

@MrYamous MrYamous requested a review from xabbuh as a code owner March 14, 2021 19:15
@Nyholm
Copy link
Member

Nyholm commented Mar 15, 2021

Thank you.

Im not too confident/knowledgeable about this feature, but should it be applied everywhere? Or is it only for some specific use cases?

@MrYamous
Copy link
Contributor Author

I think both are possible.
In my opinion, it can be a good thing to show this method by default as it allows to introduce natively a difference between the initially returned form and the one returned when the submission is invalid.

@xabbuh xabbuh added this to the 5.3 milestone Mar 26, 2021
@xabbuh
Copy link
Member

xabbuh commented Mar 26, 2021

IMO we should document this only once. Not sure though what would be the best place for it.

@javiereguiluz javiereguiluz mentioned this pull request Apr 9, 2021
Merged
@javiereguiluz
Copy link
Member

@MrYamous thanks a lot for taking care of updating this!

Some other changes were required to finish this update. Describing them in this PR was complex and I tried, but failed, to add some commits to this Pull Request.

That's why I've created #15217 based on this PR. The new PR contains your original commit, so you get full credit for your work. That's why I'm closing this one. Thanks!

javiereguiluz added a commit that referenced this pull request Sep 23, 2021
@javiereguiluz
minor #15217 [Form][FrameworkBundle] Replace render() with new render…
29f610f 
…Form() in form documentation (MrYamous, javiereguiluz)

This PR was submitted for the 5.4 branch but it was merged into the 5.3 branch instead.

Discussion
----------

[Form][FrameworkBundle] Replace render() with new renderForm() in form documentation

This adds some missing changes to #15105 and fixes #14844.

Commits
-------

fdb7b67 Update code to the latest helper behavior
773e816 More changes for forms
4b259cc Replace render by new renderForm method in form documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@MrYamous @Nyholm @xabbuh @javiereguiluz @carsonbot