Skip to content

[Security] rename User to InMemoryUser #15157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 26, 2021

fixes #15111

@xabbuh xabbuh added this to the 5.3 milestone Mar 26, 2021
@carsonbot carsonbot changed the title rename User to InMemoryUser [Security] rename User to InMemoryUser Mar 27, 2021
@javiereguiluz
Copy link
Member

Thanks for this contribution!

Given that this is an important change, and to make the transition smoother to users (and to Google search results) we may add a comment about how this class was renamed. We do the same in other parts of the docs, e.g.:

.. versionadded:: 4.3

    The :class:`Symfony\\Component\\HttpKernel\\Event\\ExceptionEvent` class was
    introduced in Symfony 4.3. In previous versions it was called
    ``Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent``.

@wouterj
Copy link
Member

wouterj commented Mar 27, 2021

I would do this as a code comment: // The InMemoryUser class was introduced in Symfony 5.3. In previous versions it was called User. (IIRC, we also applied that tactic for some renames that are often used in non-related code)

@javiereguiluz
Copy link
Member

Thanks Christian! I've added the comments as suggested by Wouter and they look nice. Cheers!

@chalasr
Copy link
Member

chalasr commented Apr 16, 2021

Big thanks to Christian and reviewers.

@xabbuh xabbuh deleted the issue-15111 branch April 19, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Rename User to InMemoryUser
5 participants