Skip to content

[Framework reference] Fix parent node for retry_failed configuration #15190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Apr 5, 2021

Hello ! Just noticed of this missing parent node for retry_failed http_client configuration.
As this feature was created for 5.2, I targetted this branch.

Let me know if I had to change something.

@Nyholm
Copy link
Member

Nyholm commented Apr 6, 2021

Awesome.

Thank you. You are correct and I agree with this. However, this PR is a duplicate of #15153.

@Jibbarth
Copy link
Contributor Author

Jibbarth commented Apr 6, 2021

Oh, I'm so sorry, I haven't looked enough. Sot let me close this PR 🙂

Thanks for the review @Nyholm 👍

@Jibbarth Jibbarth closed this Apr 6, 2021
@Nyholm
Copy link
Member

Nyholm commented Apr 6, 2021

No worries. I appreciate that you wanted to fix this.

@Jibbarth Jibbarth deleted the patch-2 branch October 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants