Skip to content

Fix example code of customization of bootstrapping in test #15428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

sudo-barun
Copy link
Contributor

The change is copied from Symfony 4.4.

@wouterj
Copy link
Member

wouterj commented Jun 17, 2021

Hi @sudo-barun! Thanks for taking the time to submit a PR.

However, I'm unsure if I can follow why you proposed this change. The existing example is a direct copy from the 5.3 testing recipe: https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/5.3/tests/bootstrap.php (this probably changed since 4.4, which explains why 4.4 and 5.3 are different)

@sudo-barun
Copy link
Contributor Author

Hi @wouterj

If you look at https://symfony.com/doc/5.3/testing/bootstrap.html, you can see that the first paragraph talks about "clearing the cache", but the code sample does not show anything about clearing cache.

I hope this clarifies your question. Let me know if there is any modification to be made.

@wouterj wouterj changed the base branch from 5.3 to 5.4 October 9, 2022 13:47
@wouterj wouterj merged commit 61cd54d into symfony:5.4 Oct 9, 2022
@wouterj
Copy link
Member

wouterj commented Oct 9, 2022

Sorry for not getting back to you, @sudo-barun. I understand what you mean now, the modernization of the article was done by a bit too much copy-paste :)

I've added a commit to this PR to make the article a bit more clear (and describe the bootstrap proces in a bit more detail).

Thanks for the contribution!

wouterj added a commit that referenced this pull request Oct 9, 2022
* 5.4:
  Document new Logstash handler argument
  Example remote ElasticsearchLogstashHandler
  [#15428] Add a bit more detail to bootstrap article
  Fix example code of customization of bootstrapping in test
  [#15186] Update example
  Adding full subscriber example
  [Validator] Add hint for testing custom constraints
wouterj added a commit that referenced this pull request Oct 9, 2022
* 6.0:
  Remove 5.4 versionadded
  Document new Logstash handler argument
  Example remote ElasticsearchLogstashHandler
  [#15428] Add a bit more detail to bootstrap article
  Fix example code of customization of bootstrapping in test
  [#15186] Update example
  Adding full subscriber example
  [Validator] Add hint for testing custom constraints
wouterj added a commit that referenced this pull request Oct 9, 2022
* 6.1:
  Remove 5.4 versionadded
  Document new Logstash handler argument
  Example remote ElasticsearchLogstashHandler
  [#15428] Add a bit more detail to bootstrap article
  Fix example code of customization of bootstrapping in test
  [#15186] Update example
  Adding full subscriber example
  [Validator] Add hint for testing custom constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants