Fix example code of customization of bootstrapping in test #15428
Conversation
|
Hi @sudo-barun! Thanks for taking the time to submit a PR. However, I'm unsure if I can follow why you proposed this change. The existing example is a direct copy from the 5.3 testing recipe: https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/5.3/tests/bootstrap.php (this probably changed since 4.4, which explains why 4.4 and 5.3 are different) |
|
Hi @wouterj If you look at https://symfony.com/doc/5.3/testing/bootstrap.html, you can see that the first paragraph talks about "clearing the cache", but the code sample does not show anything about clearing cache. I hope this clarifies your question. Let me know if there is any modification to be made. |
The change is copied from Symfony 4.4.
|
Sorry for not getting back to you, @sudo-barun. I understand what you mean now, the modernization of the article was done by a bit too much copy-paste :) I've added a commit to this PR to make the article a bit more clear (and describe the bootstrap proces in a bit more detail). Thanks for the contribution! |
* 5.4: Document new Logstash handler argument Example remote ElasticsearchLogstashHandler [#15428] Add a bit more detail to bootstrap article Fix example code of customization of bootstrapping in test [#15186] Update example Adding full subscriber example [Validator] Add hint for testing custom constraints
* 6.0: Remove 5.4 versionadded Document new Logstash handler argument Example remote ElasticsearchLogstashHandler [#15428] Add a bit more detail to bootstrap article Fix example code of customization of bootstrapping in test [#15186] Update example Adding full subscriber example [Validator] Add hint for testing custom constraints
* 6.1: Remove 5.4 versionadded Document new Logstash handler argument Example remote ElasticsearchLogstashHandler [#15428] Add a bit more detail to bootstrap article Fix example code of customization of bootstrapping in test [#15186] Update example Adding full subscriber example [Validator] Add hint for testing custom constraints
The change is copied from Symfony 4.4.