[Mercure] Compatibility with the Docker integration and various improvements #16293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 The documentation for the configuration of mercure seems quite wrong: it has a big "caution" block stating that the `MERCURE_JWT_SECRET` should contain an _actual JWT_ ... instead of a secret, which is weird (and definitely not how it works). I propose to remove these (maybe out of date?) parts to prevent further confusion (_I spent a full day examining the actual source to understand what was really needed in the env var_). Also, added a tip on how setting the cookies twice would not work. PS: I created this PR against the 5.3 (current) branch since the 4.4 branch does not have the same paragraphs. Hope it's good.
carsonbot
changed the title
dunglas
force-pushed
the
fix/mercure-docker
branch
from
c3dbd8a to
142a6f9
Compare
azjezz
reviewed
Dec 16, 2021
chalasr
reviewed
Dec 16, 2021
Indeed, done. |
Co-authored-by: Robin Chalas <[email protected]>
dunglas
force-pushed
the
fix/mercure-docker
branch
from
0a1de77 to
e35f1cc
Compare
azjezz
reviewed
Dec 16, 2021
azjezz
reviewed
Dec 16, 2021
azjezz
reviewed
Dec 16, 2021
azjezz
reviewed
Dec 16, 2021
azjezz
reviewed
Dec 16, 2021
azjezz
reviewed
Dec 16, 2021
azjezz
reviewed
Dec 16, 2021
Co-authored-by: Saif Eddin Gmati <[email protected]>
Co-authored-by: Saif Eddin Gmati <[email protected]>
Co-authored-by: Saif Eddin Gmati <[email protected]>
Co-authored-by: Saif Eddin Gmati <[email protected]>
Co-authored-by: Saif Eddin Gmati <[email protected]>
Co-authored-by: Saif Eddin Gmati <[email protected]>
|
Thanks a lot Kévin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #16151. Closes dunglas/symfony-docker#200.