Update best_practices.rst #16342
Closed
Update best_practices.rst #16342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 5.4 branch. Discussion ---------- Update best_practices.rst Commits ------- b909ece Update best_practices.rst
* 5.4: Update best_practices.rst
javiereguiluz
force-pushed
the
patch-11
branch
from
a3238aa to
73e5750
Compare
|
I'm closing this manually because I think there was some issue while upmerging #16341 and the changes were already applied, so I can't merge this PR because there are no changes now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #16341 for symfony v6 php v8