Skip to content

Mentioning svelte as a valid loader override type #17337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

weaverryan
Copy link
Member

Hi!

Minor tweak for symfony/webpack-encore#781

We could also document svelte itself, though there is also a proposed UX svelte component which, if merged, would be an even better option (and it would leverage this new feature in Encore).

Cheers!

@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Oct 10, 2022
@carsonbot carsonbot added this to the next milestone Oct 10, 2022
@javiereguiluz
Copy link
Member

Thanks Ryan!

I added Waiting Code Merge label because I think we need a new release/tag on Encore repository before merging this.

@zairigimad
Copy link
Contributor

Hello Ryan what about a new page like this one to demonstrate the enableSvelte ?
https://symfony.com/doc/current/frontend/encore/reactjs.html

@weaverryan
Copy link
Member Author

@zairigimad Yes, probably - but it should also mention symfony/ux#498 and both React and Vue pages need to be updated to mention to mention their UX components as well. I'd love if someone made a PR to the docs for all of that ;)

@zairigimad
Copy link
Contributor

@zairigimad Yes, probably - but it should also mention symfony/ux#498 and both React and Vue pages need to be updated to mention to mention their UX components as well. I'd love if someone made a PR to the docs for all of that ;)

I can add a note 🗒️ in React an Vue pages to mentien symfony ux :D

@javiereguiluz
Copy link
Member

Ryan, thanks for tagging a new Encore release. This is now merged.

@javiereguiluz javiereguiluz merged commit afba7aa into symfony:4.4 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants