Skip to content

[Form] Fix selectedchoice test link #17352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2022
Merged

[Form] Fix selectedchoice test link #17352

merged 1 commit into from
Oct 15, 2022

Conversation

HeahDude
Copy link
Contributor

The current link looks buggy to me, before:

Screenshot 2022-10-15 at 10 45 16 AM

After (with local rendering):

Screenshot 2022-10-15 at 10 45 50 AM

@HeahDude HeahDude requested a review from xabbuh as a code owner October 15, 2022 08:46
@carsonbot carsonbot added this to the 6.2 milestone Oct 15, 2022
@HeahDude HeahDude changed the base branch from 6.2 to 4.4 October 15, 2022 08:46
@xabbuh xabbuh modified the milestones: 6.2, 4.4 Oct 15, 2022
@javiereguiluz
Copy link
Member

Very nice fix! Thanks Jules.

@javiereguiluz javiereguiluz merged commit 5ab1ff9 into symfony:4.4 Oct 15, 2022
@HeahDude HeahDude deleted the minor/fix-selectedchoice_test-link branch October 15, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HeahDude @javiereguiluz @xabbuh @carsonbot