Skip to content

[Clock] Documentation for new Clock component #17435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

[Clock] Documentation for new Clock component #17435

merged 1 commit into from
Nov 24, 2022

Conversation

dbrumann
Copy link
Contributor

Closes #17074

@carsonbot carsonbot added this to the 6.2 milestone Nov 16, 2022
@dbrumann dbrumann force-pushed the issue_17074/clock_doc branch 4 times, most recently from 6ecc91e to 3bc369f Compare November 16, 2022 20:10
OskarStark
OskarStark reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbrumann dbrumann force-pushed the issue_17074/clock_doc branch 2 times, most recently from e60870f to d14007e Compare November 17, 2022 07:48
@OskarStark
Copy link
Contributor

The Code-Blocks stuff can be ignored

xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
xabbuh
xabbuh reviewed Nov 18, 2022
View reviewed changes
@dbrumann dbrumann force-pushed the issue_17074/clock_doc branch from d14007e to 9a6daec Compare November 18, 2022 15:26
javiereguiluz
javiereguiluz approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrumann thanks a lot for contributing these docs!

I like your proposed contents a lot and I don't have any comment/tweak to do about them 🙂 My only comment is about MonotonicClock, which is not explained in these docs and I don't fully understand it.

But maybe we can leave it for a future PR. Thanks.

wouterj
wouterj reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Denis!

Sorry to be the third doc member adding lots of annotations. I'm also fine with doing the changes while merging :)

@dbrumann
Copy link
Contributor Author

No problem. I will work on the changes tomorrow during my train ride. Keep them coming.

@dbrumann dbrumann force-pushed the issue_17074/clock_doc branch from 9a6daec to d41f598 Compare November 19, 2022 18:05
@dbrumann
Copy link
Contributor Author

@javiereguiluz I added a new section describing the purpose of the monotonic clock. Unfortunately, I couldn't come up with a relevant code snippet but maybe we don't need one or someone else has a good idea?

@dbrumann dbrumann force-pushed the issue_17074/clock_doc branch from d41f598 to 952e618 Compare November 19, 2022 18:45
OskarStark
OskarStark reviewed Nov 19, 2022
View reviewed changes
@dbrumann dbrumann force-pushed the issue_17074/clock_doc branch from 952e618 to 24e3994 Compare November 22, 2022 17:56
@javiereguiluz javiereguiluz merged commit c9b27cb into symfony:6.2 Nov 24, 2022
@javiereguiluz
Copy link
Member

This is now merged 🥳

Denis, thanks a lot for this nice contribution! And thanks to our great reviewers too.

@symfony symfony deleted a comment from dbrumann Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

@OskarStark OskarStark OskarStark left review comments

@xabbuh xabbuh xabbuh left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Clock Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[Clock] A new component to decouple applications from the system clock
6 participants
@dbrumann @OskarStark @javiereguiluz @wouterj @xabbuh @carsonbot