Skip to content

[Security] Merging "list" into text #17438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

ThomasLandauer
Copy link
Contributor

Reason: "a few guidelines" sounded odd, cause the first was no guideline (but a rule), and the second was still no guideline (but more details to first).

Reason: "a few guidelines" sounded odd, cause the first was no guideline (but a rule), and the second was still no guideline (but more details to first).
@carsonbot carsonbot added this to the 5.4 milestone Nov 18, 2022
@OskarStark
Copy link
Contributor

Thomas, thanks again for this proposal, but to be honest, this does not differ much from the original sentences. Yes, it looks a bit different, but how it is displayed is opinionated in my eyes. Other than that, it would be more helpful to close issues we have and open PRs for undocumented features 🙏

That does not mean your contributions are not welcome, but they take time for you and us, and does not add much value to the overall docs.

I am against merging this PR, but lets see, what the others think.

Thank you for your understanding

ping @symfony/team-symfony-docs

@carsonbot carsonbot changed the title Merging "list" into text [Security] Merging "list" into text Nov 21, 2022
@javiereguiluz javiereguiluz merged commit 903893c into symfony:5.4 Nov 21, 2022
@javiereguiluz
Copy link
Member

I was divided about what to do here ... but at the end I merged it because the original list looked a bit weird compared to a normal paragraph.

But I understand Oskar's comment because we always prefer to merge PRs that close pending issues ... although all contributions are welcome. Cheers.

@ThomasLandauer ThomasLandauer deleted the patch-6 branch November 21, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants