[Framework] clearified base_uri behavior with extra examples #17439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c33s
changed the title
|
@nicolas-grekas, given the examples, is this really the expected behavior? |
|
That's correct and that maps to the RFC for relative URL resolution.
|
|
Thanks for the feedback |
OskarStark
approved these changes
Nov 19, 2022
javiereguiluz
force-pushed
the
added-another-base-uri-example
branch
from
5abeded to
97b942f
Compare
|
Julian, thanks for improving these examples in the docs. |
|
happy to help |
|
For people coming from Google to this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some more examples with an extra directory depth. this should better document the behavior for the
base_uriparameter in combination with the leading slash in the relative url.took some "reallife" url as example as
foo/bar/bazwouldn't be so clear with only one letter difference betweenbarandbaz. i only added one "foo" url and the urls withapiin the path, the others rows are only changed because of the new intending. even if some of the examples are redundant i personally would keep them as the extra examples clearify the behavior.cost me quite some time to figure that out. hope this small addition helps people not to fall for the same.
related to: symfony/symfony#39724