Skip to content

[Mailer] Fix some usages of DataPart and File #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

[Mailer] Fix some usages of DataPart and File #17457

merged 1 commit into from
Nov 22, 2022

Conversation

javiereguiluz
Copy link
Member

The BodyFile class was renamed to File in https://github.com/symfony/symfony/pull/48060/files and there were some minor issues with some parenthesis in the code.

@javiereguiluz javiereguiluz added this to the 6.2 milestone Nov 22, 2022
@OskarStark OskarStark changed the title [Mailer] Fix some usages of DataPart and File [Mailer] Fix some usages of DataPart and File Nov 22, 2022
@OskarStark
Copy link
Contributor

Do we need a versionadded?

@javiereguiluz
Copy link
Member Author

Not a special one because BodyFile was introduced in 6.2 and renamed to File in 6.2 too. So, the existing versionadded directive should be enough.

@javiereguiluz javiereguiluz merged commit a3b90b8 into symfony:6.2 Nov 22, 2022
@javiereguiluz javiereguiluz deleted the fix_email_parts branch November 22, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Mailer Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @OskarStark @carsonbot