[PropertyInfo] Update property_info.rst #17459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Symfony 6.1 the Method `Type::getCollectionValueType() : ?self` (5.0) was changed to `Type::getCollectionValueTypes() : array` (6.1) the Docs are missleading i ran into an error after migrating to 6.1
carsonbot
changed the title
mdoutreluingne
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Good catch
I also see that getCollectionKeyType() is deprecated since Symfony 5.3 for getCollectionKeyTypes(), can you also do the patching?
These two methods have been deprecated since symfony 5.3.
I think it should target the 5.4 branch
|
hey, this is my first contribution. So i assume you merge upwards and you meant that i should do the changes against 5.4 ? :D so this would be #17474 then. Please correct me if im wrong. Thanx guys 👍🏻 |
|
Thanks for creating another PR with the correct target branch. You can close this PR |
javiereguiluz
added a commit
that referenced
this pull request
Dec 1, 2022
This PR was merged into the 5.4 branch. Discussion ---------- [PropertyInfo] Update property_info.rst Ref #17459. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 80095c6 Update property_info.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony 6.1 the Method
Type::getCollectionValueType() : ?self(5.0) was changed toType::getCollectionValueTypes() : array(6.1) the Docs are missleading and i ran into an error after migrating to 6.1