Skip to content

[Security] WIP - make:security:form-login is now available in MakerBundle #17481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrushlow
Copy link
Contributor

@jrushlow jrushlow commented Nov 29, 2022

MakerBundle is going to introduce a new command to generate and configure the files needed for FormLogin in SecurityBundle.

Not sure if we should completely remove the "manual" howto in the docs or go with something like I have here.

Note: Command name and output subject to change until we merge, I'll update this PR accordingly. In the meantime, feedback welcomed!

Note: Additional make:security:* commands to follow shortly.

Blockers:

@carsonbot carsonbot added this to the 5.4 milestone Nov 29, 2022
@carsonbot carsonbot changed the title WIP - [security] make:security:form-login is now available in MakerBundle [Security] WIP - make:security:form-login is now available in MakerBundle Nov 29, 2022
Copy link
Contributor

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should delete the manual steps. At the very least, they document the files that the maker command creates so that users who do use the command know what they are required to do with each file.

@alamirault
Copy link
Contributor

If we want document it, we must take example on this on same page I think

The easiest way to generate a user class is using the make:user command
from the MakerBundle_:

But explaining how it works before is very important, maybe make:security:form-login must be added in a tips section after explanation ?

@javiereguiluz javiereguiluz force-pushed the feature/make-security-form-login branch from 6878e34 to a6b2fd0 Compare January 23, 2024 15:04
@javiereguiluz javiereguiluz merged commit 10daf0a into symfony:5.4 Jan 23, 2024
@javiereguiluz
Copy link
Member

Thanks Jesse! We finally merged this PR to mention the make:security:form-login command.

@jrushlow jrushlow deleted the feature/make-security-form-login branch February 19, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants