Removing note about Kernel configuration
#17515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 5.4, there's nothing to configure anymore in the kernel: https://github.com/symfony/recipes/blob/main/symfony/framework-bundle/5.4/src/Kernel.php So PHP&XML routes are loaded automatically - or aren't they?
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Dec 5, 2022
Second part of symfony#17515 for reworded note
|
They're not, PHP was added in 6.1 & XML was never added. |
|
Well, looks like I forgot my own issue symfony/symfony#45116 where you already told me the same ;-) Anyway, I don't know what needs to be done in the Kernel in 5.4 and 6.0 to get PHP config going. Do you? When telling people to "update the Link to the page: https://symfony.com/doc/current/routing.html |
|
There's an example here: https://symfony.com/doc/5.4/configuration.html#configuration-formats But yeah, a link to that page might be nice. |
|
Thanks, I'm closing here.
|
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Dec 6, 2022
Info is taken from symfony#17515 (comment)
javiereguiluz
added a commit
that referenced
this pull request
Dec 8, 2022
javiereguiluz
pushed a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Dec 8, 2022
Info is taken from symfony#17515 (comment)
javiereguiluz
added a commit
that referenced
this pull request
Dec 8, 2022
This PR was merged into the 6.1 branch. Discussion ---------- [Routing] Adding default PHP format Info is taken from #17515 (comment) Commits ------- 483ea42 Adding default PHP format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5.4, there's nothing to configure anymore in the kernel: https://github.com/symfony/recipes/blob/main/symfony/framework-bundle/5.4/src/Kernel.php So PHP&XML routes are loaded automatically - or aren't they?