Skip to content

[Form] Fix choice_label #17625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2022
Merged

[Form] Fix choice_label #17625

merged 1 commit into from
Dec 27, 2022

Conversation

erichard
Copy link
Contributor

match cannot by used directly by choice_label as the $choice variable does not exist

@erichard erichard requested a review from xabbuh as a code owner December 27, 2022 10:20
@javiereguiluz javiereguiluz added this to the 5.4 milestone Dec 27, 2022
@carsonbot carsonbot changed the title Fix choice_label [Form] Fix choice_label Dec 27, 2022
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 December 27, 2022 14:50
@javiereguiluz
Copy link
Member

Good catch @erichard! Thanks and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 71b11c3 into symfony:5.4 Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@erichard @javiereguiluz @carsonbot