Skip to content

[DependencyInjection] Allow injecting the current env into php config closures #17639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

[DependencyInjection] Allow injecting the current env into php config closures #17639

merged 1 commit into from
Feb 21, 2023

Conversation

alexandre-daubois
Copy link
Member

Resolves #17367

Gave this a try, not exactly sure of where this should be located in the documentation. Explicitly Configuring Services and Arguments seemed the good section to me. If it's not, I'll be happy to do required updates! 👍

@javiereguiluz javiereguiluz added this to the 6.2 milestone Feb 21, 2023
@javiereguiluz javiereguiluz merged commit c658aca into symfony:6.2 Feb 21, 2023
@javiereguiluz
Copy link
Member

Nice addition! Sorry it took us so long to merge.

@alexandre-daubois
Copy link
Member Author

No worries @javiereguiluz! Thank you for your kind messages on each of my contribution 🤩

@HypeMC HypeMC mentioned this pull request Feb 26, 2023
Merged
javiereguiluz added a commit that referenced this pull request Mar 15, 2023
@javiereguiluz
minor #17969 [HttpCache] Inject $env in example (HypeMC)
ea50dc7 
This PR was merged into the 6.2 branch.

Discussion
----------

[HttpCache] Inject `$env` in example

A sort of followup to #17639, IMO makes the example a bit clearer.

Commits
-------

7ae2f94 [HttpCache] Inject $env in example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Allow injecting the current env into php config c…
3 participants
@alexandre-daubois @javiereguiluz @carsonbot