[Security] Prevent unneeded implementation of PasswordHasherAwareInterface when migrating passwords
#17641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 2, 2023
MatTheCat
added a commit
to MatTheCat/symfony-docs
that referenced
this pull request
Jan 2, 2023
Co-authored-by: Oskar Stark <[email protected]>
wouterj
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
Thanks @MatTheCat!
Very useful to receive such improvements from experienced bug triagers :)
MatTheCat
added a commit
to MatTheCat/symfony-docs
that referenced
this pull request
Jan 2, 2023
Co-authored-by: Wouter de Jong <[email protected]>
…erface` when migrating passwords
javiereguiluz
force-pushed
the
dynamic-password-hasher
branch
from
d6d711e to
1d09493
Compare
|
Thank you Mathieu ... and thanks to reviewers too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to avoid issues like symfony/symfony#48348 or symfony/symfony#48825