[DependencyInjection] Exclude referencing service (self) in TaggedIterator
#17709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Jan 10, 2023
| @@ -692,6 +692,11 @@ iterator, add the ``exclude`` option: | |||
|
|
|||
| The ``exclude`` option was introduced in Symfony 6.1. | |||
|
|
|||
| .. versionadded:: 6.3 | |||
There was a problem hiding this comment.
When tagging 7.0 all versionadded directives will be drop, so maybe it should be a note/tip + versionadded ?
There was a problem hiding this comment.
Yes that would be better 👍
There was a problem hiding this comment.
That was my main concern about this PR. Updated it with a note+versionadded, thank you both!
alexandre-daubois
force-pushed
the
exclude-self
branch
from
a7f2bc4 to
dd613a8
Compare
OskarStark
approved these changes
Jan 11, 2023
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17656